feat(auth): delegate CORM sessions and permissions to ERP

This commit is contained in:
2026-10-22 16:42:12 +09:00
parent dfe91196cb
commit 92986eb1cc
7 changed files with 281 additions and 105 deletions
+151
View File
@@ -0,0 +1,151 @@
"""ERP 권한 차단·장애·경로 우회를 DB/외부 네트워크 없이 검증한다."""
import os
import unittest
from unittest.mock import patch
from urllib.parse import parse_qs, urlsplit
import httpx
from fastapi import FastAPI, Request
from fastapi.responses import JSONResponse
from fastapi.testclient import TestClient
from erp_auth import AuthGuardMiddleware
class ErpAuthTests(unittest.TestCase):
def setUp(self):
self.env = patch.dict(os.environ, {
"APP_ROOT_PATH": "/corm", "MAIN_LOGIN_URL": "https://erp.example/login",
"ERP_AUTH_URL": "http://erp.test/api/auth/check", "SESSION_COOKIE_NAME": "erp_session",
"INTERNAL_SERVICE_TOKEN": "system-only-test-token",
})
self.env.start()
self.addCleanup(self.env.stop)
self.calls = []
self.status = 200
self.payload = {"module": "corm", "user": {"email": "worker@example.test", "name": "Worker"}}
self.error = None
self.hits = []
self.real_client = httpx.AsyncClient
def handler(request):
self.calls.append(request)
if self.error:
raise self.error
return httpx.Response(self.status, json=self.payload)
def client_factory(**kwargs):
self.assertEqual(kwargs, {
"timeout": 3.0, "follow_redirects": False, "trust_env": False,
"cookies": {"erp_session": "browser-cookie"},
})
return self.real_client(transport=httpx.MockTransport(handler), **kwargs)
self.mock_client = patch("erp_auth.httpx.AsyncClient", side_effect=client_factory)
self.mock_client.start()
self.addCleanup(self.mock_client.stop)
app = FastAPI()
app.add_middleware(AuthGuardMiddleware)
@app.api_route("/{path:path}", methods=["GET", "POST"])
async def protected(request: Request, path: str):
self.hits.append(path)
return JSONResponse({"user": getattr(request.state, "erp_user", None)})
self.client = TestClient(app, follow_redirects=False)
def get(self, path="/api/items", cookie=True, headers=None):
headers = dict(headers or {})
if cookie:
headers["Cookie"] = "erp_session=browser-cookie; unrelated=do-not-forward"
return self.client.get(path, headers=headers)
def test_authorized_identity_and_only_session_cookie_forwarded(self):
r = self.get()
self.assertEqual(r.status_code, 200)
self.assertEqual(r.json()["user"], self.payload["user"])
call = self.calls[0]
self.assertEqual(str(call.url), "http://erp.test/api/auth/check?module=corm")
self.assertEqual(call.headers["cookie"], "erp_session=browser-cookie")
self.assertNotIn("x-service-token", call.headers)
self.assertNotIn("set-cookie", r.headers)
def test_no_cookie_api_401_and_html_redirect_with_query(self):
self.assertEqual(self.get(cookie=False).status_code, 401)
r = self.get("/corm/returns?status=open&term=a%20b", cookie=False)
self.assertEqual(r.status_code, 302)
parts = urlsplit(r.headers["location"])
self.assertEqual(parts.netloc, "erp.example")
self.assertEqual(parse_qs(parts.query)["next"], ["/corm/returns?status=open&term=a%20b"])
self.assertFalse(self.calls)
self.assertFalse(self.hits)
def test_permission_removal_and_deleted_user_take_effect_next_request(self):
self.assertEqual(self.get().status_code, 200)
self.status = 403
self.assertEqual(self.get().status_code, 403)
self.assertEqual(self.get("/", headers={"Accept": "text/html"}).status_code, 403)
self.status = 401
self.assertEqual(self.get().status_code, 401)
self.assertEqual(self.get("/").status_code, 302)
self.assertEqual(len(self.hits), 1)
self.assertEqual(len(self.calls), 5)
def test_erp_failures_never_allow_access(self):
for status in (302, 404, 422, 500, 503):
with self.subTest(status=status):
self.status = status
self.assertEqual(self.get().status_code, 503)
self.error = httpx.ConnectError("offline")
self.assertEqual(self.get().status_code, 503)
self.error = httpx.ReadTimeout("timeout")
r = self.get("/")
self.assertEqual(r.status_code, 503)
self.assertEqual(r.headers["cache-control"], "no-store")
self.assertFalse(self.hits)
def test_malformed_or_wrong_module_responses_are_denied(self):
for payload in (None, [], {}, {"module": "order", "user": {"email": "a"}},
{"module": "corm", "user": {"email": ""}},
{"module": "corm", "user": {"email": 1}}):
with self.subTest(payload=payload):
self.payload = payload
self.assertEqual(self.get().status_code, 503)
self.assertFalse(self.hits)
def test_exempt_paths_are_exact_and_corm_prefix_is_handled(self):
for path in ("/login", "/logout", "/health/db", "/admin/oauth/callback?code=x",
"/static/app.js", "/corm/health/db", "/corm/static/app.js"):
with self.subTest(path=path):
self.assertEqual(self.get(path, cookie=False).status_code, 200)
for path in ("/login-bypass", "/health/secrets", "/admin/oauth/callback/secret"):
with self.subTest(path=path):
self.assertEqual(self.get(path, cookie=False).status_code, 302)
self.assertFalse(self.calls)
def test_existing_machine_auth_and_invalid_token(self):
self.assertEqual(self.get(cookie=False, headers={"X-Service-Token": "system-only-test-token"}).status_code, 200)
self.assertEqual(self.get(cookie=False, headers={"X-Service-Token": "wrong"}).status_code, 401)
self.assertEqual(len(self.hits), 1)
self.assertFalse(self.calls)
def test_real_application_page_and_login_logout_delegation(self):
import main
client = TestClient(main.app, follow_redirects=False)
page = client.get("/", headers={"Cookie": "erp_session=browser-cookie"})
self.assertEqual(page.status_code, 200)
self.assertNotIn("set-cookie", page.headers)
self.status = 403
self.assertEqual(client.get("/", headers={"Cookie": "erp_session=browser-cookie"}).status_code, 403)
self.assertEqual(client.get("/api/config").status_code, 401)
login = client.get("/login", params={"next": "/corm/?tab=returns"})
self.assertEqual(login.status_code, 302)
self.assertEqual(parse_qs(urlsplit(login.headers["location"]).query)["next"], ["/corm/?tab=returns"])
logout = client.get("/logout")
self.assertEqual(logout.status_code, 302)
self.assertEqual(logout.headers["location"], main.MAIN_LOGOUT_URL)
self.assertNotIn("set-cookie", logout.headers)
if __name__ == "__main__":
unittest.main()
+1 -2
View File
@@ -16,9 +16,8 @@ import requests
_import_cache_dir = tempfile.TemporaryDirectory()
os.environ["SETTINGS_CACHE_FILE"] = str(Path(_import_cache_dir.name) / "settings.json")
# 서버판(dbx-corm)은 SSO 미들웨어가 세션 비밀값을 요구하고, 로그인 안 된 요청을 401 로 막는다.
# 서버판(dbx-corm)은 ERP 중앙 인증으로 로그인 안 된 요청을 401 로 막는다.
# 테스트는 서비스 간 호출 토큰(X-Service-Token)으로 통과한다.
os.environ.setdefault("SESSION_SECRET_KEY", "test-only-session-secret")
os.environ["INTERNAL_SERVICE_TOKEN"] = "test-service-token"
import main