feat(project): projects visible to members only, admins included
Admins no longer see projects they are not owner/member of: sidebar list, project list API, project pages, search, inbox, notifications, reminders and trash all follow access.visible_project_ids. Only the super admin still sees every project. Member assignment stays admin-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,80 @@
|
||||
"""프로젝트는 멤버(owner 포함)만 — 관리자도 멤버가 아니면 안 보인다, 예외는 슈퍼관리자(2026-10-07). DB 없이."""
|
||||
import importlib
|
||||
import sys
|
||||
import unittest
|
||||
from types import SimpleNamespace
|
||||
from unittest.mock import Mock, patch
|
||||
|
||||
from fastapi import FastAPI
|
||||
from fastapi.testclient import TestClient
|
||||
|
||||
from app.modules.project import access
|
||||
from app.store import SUPER_ADMIN_EMAIL
|
||||
|
||||
api = importlib.import_module("app.modules.project.router")
|
||||
|
||||
ADMIN = {"email": "admin@test.local", "role": "admin"}
|
||||
SUPER = {"email": SUPER_ADMIN_EMAIL, "role": "admin"}
|
||||
MEMBER = {"email": "bob@test.local", "role": "user"}
|
||||
|
||||
|
||||
class FakeStore:
|
||||
"""프로젝트 1 = bob 멤버, 2 = admin 멤버. list_projects(member_email) 는 그 사람이 owner·멤버인 것만."""
|
||||
members = {1: {"bob@test.local"}, 2: {"admin@test.local"}}
|
||||
|
||||
def __init__(self):
|
||||
self.member_email_asked = "unset"
|
||||
|
||||
def is_member(self, project_id, user_email):
|
||||
return user_email in self.members.get(project_id, set())
|
||||
|
||||
def list_projects(self, include_archived=False, member_email=None):
|
||||
self.member_email_asked = member_email
|
||||
return [{"id": pid, "parent_id": None, "name": f"P{pid}"} for pid, ms in self.members.items()
|
||||
if member_email is None or member_email in ms]
|
||||
|
||||
|
||||
class MembersOnlyTests(unittest.TestCase):
|
||||
def setUp(self):
|
||||
self.st = FakeStore()
|
||||
p = patch.object(access, "can_use_module", side_effect=lambda u: bool(u))
|
||||
p.start()
|
||||
self.addCleanup(p.stop)
|
||||
|
||||
def test_admin_sees_only_member_projects(self):
|
||||
self.assertFalse(access.can_manage_project(self.st, ADMIN, 1))
|
||||
self.assertTrue(access.can_manage_project(self.st, ADMIN, 2))
|
||||
self.assertEqual(access.visible_project_ids(self.st, ADMIN), {2})
|
||||
self.assertFalse(access.sees_all_projects(ADMIN))
|
||||
|
||||
def test_member_and_super_admin(self):
|
||||
self.assertTrue(access.can_manage_project(self.st, MEMBER, 1))
|
||||
self.assertFalse(access.can_manage_project(self.st, MEMBER, 2))
|
||||
self.assertTrue(access.can_manage_project(self.st, SUPER, 1))
|
||||
self.assertIsNone(access.visible_project_ids(self.st, SUPER)) # 전체
|
||||
self.assertTrue(access.sees_all_projects(SUPER))
|
||||
|
||||
def test_sidebar_list_is_member_only_for_admin(self):
|
||||
self.assertEqual([p["id"] for p in api._nav_projects(self.st, ADMIN, True)], [2])
|
||||
self.assertEqual(self.st.member_email_asked, "admin@test.local")
|
||||
self.assertEqual(sorted(p["id"] for p in api._nav_projects(self.st, SUPER, True)), [1, 2])
|
||||
self.assertIsNone(self.st.member_email_asked)
|
||||
|
||||
def test_project_list_api_is_member_only_for_admin(self):
|
||||
app = FastAPI()
|
||||
app.include_router(api.router)
|
||||
client = TestClient(app)
|
||||
with patch.object(api, "_require_user", return_value=ADMIN), patch.object(api, "_db_or_503", return_value=self.st):
|
||||
r = client.get("/project/api/projects")
|
||||
self.assertEqual(r.status_code, 200, r.text)
|
||||
self.assertEqual([p["id"] for p in r.json()["projects"]], [2])
|
||||
|
||||
def test_trash_is_filtered_to_member_projects(self):
|
||||
st = SimpleNamespace(list_trash=lambda: [{"id": 7, "project_id": 1}, {"id": 8, "project_id": 2}],
|
||||
**{k: getattr(self.st, k) for k in ("is_member", "list_projects")})
|
||||
self.assertEqual([t["id"] for t in api._visible_trash(st, ADMIN)], [8])
|
||||
self.assertEqual([t["id"] for t in api._visible_trash(st, SUPER)], [7, 8])
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
@@ -121,7 +121,8 @@ def _count(sql: str, *args) -> int:
|
||||
# [07] 소유자 변경은 관리자만
|
||||
# ════════════════════════════════════════════════════════════
|
||||
def test_owner_change_admin_only():
|
||||
p = _project("P-owner", ADMIN, (BOB,))
|
||||
# 관리자도 멤버가 아닌 프로젝트는 못 다룬다(2026-10-07) — 소유자를 남에게 넘긴 뒤에도 바꿀 수 있게 멤버로 둔다
|
||||
p = _project("P-owner", ADMIN, (BOB, ADMIN))
|
||||
r = req("PUT", f"/project/api/projects/{p['id']}", BOB, json={"owner_email": BOB})
|
||||
assert r.status_code == 403, r.text
|
||||
assert ST.get_project(project_id=p["id"])["owner_email"] == ADMIN
|
||||
|
||||
Reference in New Issue
Block a user