fix(project): meeting task table shared per week on the server (others' rows were invisible)

- Cause: the table lived only in each browser's localStorage
- project_db migration 025 goal_meeting_tasks (week_start, parent_id for subtask rows, task_id)
- API list/add/update/delete + apply; apply locks the row and creates the task once via the
  same helper as the task window (_create_task_for: membership, assignee check, notifications)
- Non-members see other people's rows with project/section/task hidden; only member projects
  can be picked; completed meeting is read-only (409)
- Client saves per field, refreshes every 30s / on focus, uploads rows left in this browser once
- Docs (DEPLOYMENT 025, PROJECT_MODULE, help, CLAUDE.md); tests (real PostgreSQL incl. 4
  concurrent applies -> one task, jsdom)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-12 16:06:23 +09:00
parent 4320766abd
commit b7c0f28ad2
20 changed files with 704 additions and 130 deletions
+170
View File
@@ -3348,6 +3348,176 @@ class ProjectStore:
for n, x in enumerate(order):
conn.execute("UPDATE goal_meeting_items SET sort_order = %s WHERE id = %s", (n, x))
# ── 회의록 작업 등록 표(025) — 주차별 한 표, 모두가 같이 본다. [적용] 전 줄은 고치고, [적용]은 한 번만 ──
_MT_COLS = ("id, week_start, parent_id, sort_order, title, assignee_email, project_id, stage_id, task_id, "
"created_by, updated_by, created_at, updated_at")
def _mt_conn(self) -> Any:
return self._pool.connection()
@staticmethod
def _mt_call(fn: Any) -> Any:
try:
return fn()
except psycopg_errors.UndefinedTable:
raise store.MeetingTaskMigrationNeeded()
@staticmethod
def _mt_row(r: dict[str, Any]) -> dict[str, Any]:
out = {k: r.get(k) for k in ("id", "parent_id", "sort_order", "title", "assignee_email", "project_id",
"stage_id", "task_id", "created_by", "updated_by")}
for k in ("id", "parent_id", "project_id", "stage_id", "task_id"):
out[k] = int(out[k]) if out[k] is not None else None
out["week_start"] = r["week_start"].isoformat()
out["updated_at"] = r["updated_at"].astimezone(KST).isoformat(timespec="seconds") if r.get("updated_at") else ""
for k in ("project_name", "project_status", "stage_name", "task_title", "task_project_id"):
if k in r:
out[k] = r[k]
if "task_exists" in r:
out["task_exists"] = bool(r["task_exists"])
return out
def _mt_clean(self, conn: Any, fields: dict[str, Any], *, project_id: Any = ...) -> dict[str, Any]:
"""고칠 칸 정리 — title(200자)·assignee_email·project_id·stage_id(그 프로젝트 섹션). 프로젝트가 바뀌면 섹션을 비운다."""
clean: dict[str, Any] = {}
if "title" in fields:
t = store.norm_str(fields.get("title"))
if len(t) > 200:
raise ValueError("작업 제목은 200자 이하로 입력하세요.")
clean["title"] = t
if "assignee_email" in fields:
clean["assignee_email"] = store.norm_str(fields.get("assignee_email") or "", lower=True)
pid = project_id
if "project_id" in fields:
raw = fields.get("project_id")
try:
pid = int(raw) if raw not in (None, "") else None
except (TypeError, ValueError):
raise ValueError("프로젝트 값이 올바르지 않습니다.")
clean["project_id"] = pid
if "stage_id" not in fields:
clean["stage_id"] = None
if "stage_id" in fields:
sid = fields.get("stage_id")
if sid in (None, ""):
clean["stage_id"] = None
else:
if pid in (None, ...):
raise ValueError("프로젝트를 먼저 고르세요.")
clean["stage_id"] = self._check_stage_in_project(conn, sid, int(pid))
return clean
def list_meeting_tasks(self, *, week_start: date) -> list[dict[str, Any]]:
"""그 주차 표 — 순서대로(세부 작업 줄은 부모 바로 뒤에 화면이 묶는다). 프로젝트·섹션 이름·만든 작업 존재 여부를 붙인다."""
def run() -> list[dict[str, Any]]:
with self._mt_conn() as conn:
rows = conn.execute(
"SELECT m.id, m.week_start, m.parent_id, m.sort_order, m.title, m.assignee_email, m.project_id, "
" m.stage_id, m.task_id, m.created_by, m.updated_by, m.created_at, m.updated_at, "
" p.name AS project_name, p.status AS project_status, s.name AS stage_name, "
" t.title AS task_title, t.project_id AS task_project_id, (t.id IS NOT NULL) AS task_exists "
"FROM goal_meeting_tasks m "
"LEFT JOIN projects p ON p.id = m.project_id "
"LEFT JOIN project_stages s ON s.id = m.stage_id "
"LEFT JOIN tasks t ON t.id = m.task_id "
"WHERE m.week_start = %s ORDER BY m.sort_order, m.id", (week_start,),
).fetchall()
return [self._mt_row(r) for r in rows]
return self._mt_call(run)
def get_meeting_task(self, *, item_id: int) -> dict[str, Any] | None:
def run() -> dict[str, Any] | None:
with self._mt_conn() as conn:
r = conn.execute(f"SELECT {self._MT_COLS} FROM goal_meeting_tasks WHERE id = %s", (item_id,)).fetchone()
return self._mt_row(r) if r else None
return self._mt_call(run)
def add_meeting_task(self, *, week_start: date, fields: dict[str, Any], by: str = "",
parent_id: int | None = None, task_id: int | None = None) -> dict[str, Any]:
"""줄 추가(빈 줄도). parent_id = 세부 작업 줄(같은 주차 줄 밑). task_id = 예전 브라우저 표에서 옮겨 온 이미 등록된 줄."""
who = store.norm_str(by, lower=True)
def run() -> int:
with self._mt_conn() as conn:
with conn.transaction():
self._check_meeting_open(conn, week_start)
clean = self._mt_clean(conn, fields)
if parent_id is not None:
par = conn.execute("SELECT week_start FROM goal_meeting_tasks WHERE id = %s", (parent_id,)).fetchone()
if par is None or par["week_start"] != week_start:
raise ValueError("위 줄이 이 주차 표에 없습니다.")
nxt = conn.execute("SELECT COALESCE(MAX(sort_order), -1) + 1 AS n FROM goal_meeting_tasks "
"WHERE week_start = %s", (week_start,)).fetchone()["n"]
return int(conn.execute(
"INSERT INTO goal_meeting_tasks (week_start, parent_id, sort_order, title, assignee_email, "
"project_id, stage_id, task_id, created_by, updated_by) VALUES (%s,%s,%s,%s,%s,%s,%s,%s,%s,%s) "
"RETURNING id",
(week_start, parent_id, int(nxt), clean.get("title", ""), clean.get("assignee_email", ""),
clean.get("project_id"), clean.get("stage_id"), task_id, who, who),
).fetchone()["id"])
return self.get_meeting_task(item_id=self._mt_call(run)) # type: ignore[return-value]
def update_meeting_task(self, *, item_id: int, fields: dict[str, Any], by: str = "") -> dict[str, Any]:
"""[적용] 전 줄만 고친다(줄을 잠그고 — 다른 사람이 막 [적용]한 줄은 409). 회의 완료된 주차면 잠금."""
def run() -> None:
with self._mt_conn() as conn:
with conn.transaction():
row = conn.execute("SELECT week_start, project_id, task_id FROM goal_meeting_tasks WHERE id = %s FOR UPDATE",
(item_id,)).fetchone()
if row is None:
raise KeyError(item_id)
self._check_meeting_open(conn, row["week_start"])
if row["task_id"] is not None:
raise store.GoalCellConflict("이미 [적용]해 작업으로 만든 줄입니다. 새로고침해 주세요.")
clean = self._mt_clean(conn, fields, project_id=row["project_id"])
if not clean:
return
sets = ", ".join(f"{k} = %s" for k in clean)
conn.execute(f"UPDATE goal_meeting_tasks SET {sets}, updated_by = %s, updated_at = now() WHERE id = %s",
(*clean.values(), store.norm_str(by, lower=True), item_id))
self._mt_call(run)
return self.get_meeting_task(item_id=item_id) # type: ignore[return-value]
def delete_meeting_task(self, *, item_id: int) -> dict[str, Any]:
"""줄 지우기(세부 작업 줄도 함께). 만든 작업은 라우터·화면이 따로 지운다(휴지통)."""
def run() -> dict[str, Any]:
with self._mt_conn() as conn:
with conn.transaction():
row = conn.execute(f"SELECT {self._MT_COLS} FROM goal_meeting_tasks WHERE id = %s FOR UPDATE",
(item_id,)).fetchone()
if row is None:
raise KeyError(item_id)
self._check_meeting_open(conn, row["week_start"])
conn.execute("DELETE FROM goal_meeting_tasks WHERE id = %s", (item_id,))
return self._mt_row(row)
return self._mt_call(run)
def apply_meeting_task(self, *, item_id: int, create: Any) -> tuple[dict[str, Any], bool]:
"""[적용] — 줄을 잠그고 아직 작업이 없을 때만 create(줄) 로 작업을 만들어 task_id 를 남긴다.
(줄, 이번에 만들었는가). 두 사람이 동시에 눌러도 작업은 하나. create 가 실패하면 줄은 그대로."""
def run() -> tuple[int, bool]:
with self._mt_conn() as conn:
with conn.transaction():
row = conn.execute(f"SELECT {self._MT_COLS} FROM goal_meeting_tasks WHERE id = %s FOR UPDATE",
(item_id,)).fetchone()
if row is None:
raise KeyError(item_id)
self._check_meeting_open(conn, row["week_start"])
if row["task_id"] is not None:
return item_id, False
parent_task = None
if row["parent_id"] is not None:
par = conn.execute("SELECT task_id FROM goal_meeting_tasks WHERE id = %s", (row["parent_id"],)).fetchone()
parent_task = par["task_id"] if par else None
if parent_task is None:
raise ValueError("위 줄(상위 작업)을 먼저 [적용]하세요.")
task = create(self._mt_row(row), parent_task)
conn.execute("UPDATE goal_meeting_tasks SET task_id = %s, updated_at = now() WHERE id = %s",
(int(task["id"]), item_id))
return item_id, True
iid, made = self._mt_call(run)
return self.get_meeting_task(item_id=iid), made # type: ignore[return-value]
def goal_month_targets(self, *, year: int, month: int) -> dict[str, Any]:
"""회의록 머리 — 그 달 매출 목표·실적, 로아스 목표(목표 표 숫자), 매출 단위. 목표 표가 없으면 빈 값."""
with self._pool.connection() as conn: