7f94e5efe7
- 마이그레이션 033 tasks.repeat_daily — [매일]이면 마감일·시각 비움, 마감일을 고르면 꺼짐(미적용이면 버튼 숨김·PUT 503) - 마감 칸(카드·목록·내 업무·세부 업무·업무 창)에 반복 아이콘 + "매일" - reminders.run_daily_alerts: 영업일, Project 옵션 daily_alert_times 중 지난 가장 늦은 시각마다 담당자(없으면 협업자)에게 type=daily 알림(task_reminders 로 중복 방지, 데몬 1분 주기) - 큰 알림 팝업·PC 알림 프로그램에서 매일 업무 줄은 노란 배경 - Project 옵션 "알림" 분류: 알림 시각 여러 개 추가·삭제(최대 12) - 도움말·모듈 CLAUDE.md·DEPLOYMENT(033) 갱신, 테스트 추가 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
145 lines
7.0 KiB
Python
145 lines
7.0 KiB
Python
"""Project 옵션(시스템 전체 — 처음 여는 탭·보드 카드 표지) API·검사. DB 없이 가짜 저장소로.
|
|
|
|
일반(폰트)은 브라우저 localStorage 라 서버에 없다. 수퍼관리자·Admin 만 저장, 읽기는 모듈 권한자 누구나.
|
|
"""
|
|
import importlib
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from fastapi import FastAPI
|
|
from fastapi.testclient import TestClient
|
|
from psycopg.errors import UndefinedTable
|
|
|
|
api = importlib.import_module("app.modules.project.router")
|
|
store = importlib.import_module("app.modules.project.store")
|
|
|
|
ADMIN = {"email": "Boss@Test.local", "role": "admin"}
|
|
USER = {"email": "me@test.local", "role": "user"}
|
|
PRO = {"email": "pro@test.local", "role": "pro"}
|
|
D = dict(store.PROJECT_OPTION_DEFAULTS)
|
|
|
|
|
|
class FakeStore:
|
|
def __init__(self, saved=None, *, missing=False, broken=False):
|
|
self.saved = dict(saved or {})
|
|
self.missing = missing # 029 미적용
|
|
self.broken = broken # 읽기 자체가 실패(연결 끊김 등)
|
|
self.writes = []
|
|
|
|
def get_project_options(self):
|
|
if self.broken:
|
|
raise RuntimeError("db down")
|
|
return {} if self.missing else dict(self.saved)
|
|
|
|
def set_project_options(self, *, values, updated_by):
|
|
if self.missing:
|
|
raise UndefinedTable("project_options")
|
|
self.writes.append((dict(values), updated_by))
|
|
self.saved.update(values)
|
|
|
|
|
|
class NormalizeTests(unittest.TestCase):
|
|
def test_defaults_when_nothing_saved(self):
|
|
self.assertEqual(store.normalize_project_options(None), D)
|
|
self.assertEqual(store.normalize_project_options({}), D)
|
|
|
|
def test_bad_or_unknown_saved_values_fall_back(self):
|
|
out = store.normalize_project_options({"default_view": "gantt", "board_cover": "no", "x": 1})
|
|
self.assertEqual(out, D)
|
|
|
|
def test_saved_values_used(self):
|
|
out = store.normalize_project_options({"default_view": "timeline", "board_cover": False})
|
|
self.assertEqual(out, dict(D, default_view="timeline", board_cover=False))
|
|
|
|
def test_all_view_users_normalized(self):
|
|
out = store.normalize_project_options({"all_view_users": ["B@x.kr", "a@x.kr", "b@x.kr"]})
|
|
self.assertEqual(out["all_view_users"], ["a@x.kr", "b@x.kr"])
|
|
self.assertEqual(store.normalize_project_options({"all_view_users": []})["all_view_users"], [])
|
|
self.assertIsNone(store.normalize_project_options({"all_view_users": "x"})["all_view_users"])
|
|
self.assertEqual(store.validate_project_options({"all_view_users": ["Me@X.kr"]}), {"all_view_users": ["me@x.kr"]})
|
|
self.assertEqual(store.validate_project_options({"all_view_users": None}), {"all_view_users": None})
|
|
|
|
def test_daily_alert_times(self):
|
|
self.assertEqual(D["daily_alert_times"], ["09:00"])
|
|
out = store.normalize_project_options({"daily_alert_times": ["14:00", "9:00", "09:00"]})
|
|
self.assertEqual(out["daily_alert_times"], ["09:00", "14:00"])
|
|
self.assertEqual(store.normalize_project_options({"daily_alert_times": []})["daily_alert_times"], []) # 빈 목록 = 끔
|
|
self.assertEqual(store.normalize_project_options({"daily_alert_times": ["25:00"]})["daily_alert_times"], ["09:00"])
|
|
self.assertEqual(store.validate_project_options({"daily_alert_times": ["18:30", "08:05"]}),
|
|
{"daily_alert_times": ["08:05", "18:30"]})
|
|
for bad in ("09:00", ["9시"], [""], [None], ["24:00"], ["09:00"] * 0 + [f"{h:02d}:00" for h in range(13)]):
|
|
with self.subTest(bad=bad), self.assertRaises(ValueError):
|
|
store.validate_project_options({"daily_alert_times": bad})
|
|
|
|
def test_can_all_view(self):
|
|
access = importlib.import_module("app.modules.project.access")
|
|
self.assertTrue(access.can_all_view(PRO, None)) # 설정 전 = Pro user 이상(예전 그대로)
|
|
self.assertFalse(access.can_all_view(USER, None))
|
|
self.assertTrue(access.can_all_view(USER, ["me@test.local"]))
|
|
self.assertFalse(access.can_all_view(ADMIN, ["me@test.local"]))
|
|
self.assertTrue(access.can_all_view(ADMIN, ["boss@test.local"])) # 대소문자 무시
|
|
self.assertFalse(access.can_all_view(ADMIN, []))
|
|
|
|
def test_validate_keeps_only_sent_keys(self):
|
|
self.assertEqual(store.validate_project_options({"board_cover": False}), {"board_cover": False})
|
|
|
|
def test_validate_rejects(self):
|
|
for bad in ({}, None, [], {"default_view": "gantt"}, {"board_cover": 0}, {"board_cover": "false"}, {"font": "x"},
|
|
{"all_view_users": "a@x.kr"}, {"all_view_users": ["noemail"]}, {"all_view_users": [1]}):
|
|
with self.subTest(bad=bad), self.assertRaises(ValueError):
|
|
store.validate_project_options(bad)
|
|
|
|
|
|
class OptionsApiTests(unittest.TestCase):
|
|
def setUp(self):
|
|
app = FastAPI()
|
|
app.include_router(api.router)
|
|
self.client = TestClient(app)
|
|
|
|
def call(self, method, user, st, body=None):
|
|
with patch.object(api, "_require_user", return_value=user), \
|
|
patch.object(api, "_db_or_503", return_value=st):
|
|
return self.client.request(method, "/project/api/options", json=body)
|
|
|
|
def test_anyone_with_module_reads_with_can_edit_flag(self):
|
|
st = FakeStore({"default_view": "list"})
|
|
out = self.call("GET", USER, st).json()
|
|
self.assertEqual(out, {"options": dict(D, default_view="list"), "can_edit": False})
|
|
self.assertTrue(self.call("GET", ADMIN, st).json()["can_edit"])
|
|
|
|
def test_admin_saves_only_sent_keys(self):
|
|
st = FakeStore({"default_view": "calendar"})
|
|
res = self.call("PUT", ADMIN, st, {"board_cover": False})
|
|
self.assertEqual(res.status_code, 200)
|
|
self.assertEqual(st.writes, [({"board_cover": False}, "Boss@Test.local")])
|
|
self.assertEqual(res.json()["options"], dict(D, default_view="calendar", board_cover=False))
|
|
|
|
def test_user_and_pro_cannot_save(self):
|
|
for who in (USER, PRO):
|
|
st = FakeStore()
|
|
with self.subTest(role=who["role"]):
|
|
self.assertEqual(self.call("PUT", who, st, {"board_cover": False}).status_code, 403)
|
|
self.assertEqual(st.writes, [])
|
|
|
|
def test_invalid_payload_400_without_write(self):
|
|
st = FakeStore()
|
|
for body in ({"default_view": "gantt"}, {"board_cover": "yes"}, {}, {"font": "pretendard"}, {"all_view_users": ["x"]}):
|
|
with self.subTest(body=body):
|
|
self.assertEqual(self.call("PUT", ADMIN, st, body).status_code, 400)
|
|
self.assertEqual(st.writes, [])
|
|
|
|
def test_migration_missing_read_defaults_write_503(self):
|
|
st = FakeStore(missing=True)
|
|
self.assertEqual(self.call("GET", USER, st).json()["options"], D)
|
|
res = self.call("PUT", ADMIN, st, {"board_cover": False})
|
|
self.assertEqual(res.status_code, 503)
|
|
self.assertIn("029", res.json()["detail"])
|
|
|
|
def test_page_reader_never_fails(self):
|
|
self.assertEqual(api._project_options(None), D)
|
|
self.assertEqual(api._project_options(FakeStore(broken=True)), D)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|