Files
dbx-main/tests/test_project_roles.py
T
king 89ad338024 fix(project): review fixes — access leaks, open paths, save safety, concurrency
- Subproject tasks via parent /tasks are re-filtered by current access (FULL/READ kept)
- PUT /api/projects/order: every id must be manageable; bad/duplicate ids -> 400, all-or-nothing
- Inbox, web alert popup, PC notifier open tasks via /project/t/{id}; embed=1 survives redirect;
  old /p/{home}?task= redirects READ users to the linked project
- Project page / snapshot / workload include the opened archived or sub project only
- Alerts: DB-side filters + oldest-first paging (no 50-row cut); badges counted without caps;
  my tasks keep every open task (completed capped)
- Meeting results: next-week meeting open, or own meeting open when no next meeting;
  header edits + result checks under row locks (FOR UPDATE / FOR SHARE)
- Inbox panel waits for the task window save (same retry/discard flow) before switching/closing;
  read failures stay unread
- Attachment upload removes only its own file on DB failure
- New project modal: create once, retry only failed member assignments
- update_task / update_project: locked-row validation in one transaction; completion hints from real transition
- Creator added as explicit member when another owner is chosen
- _once lock lifetime managed by refcount (no leak on failure)
- Section default assignee must still be a registered project user; follower add uses can_assign
- Docs (PROJECT_MODULE 6-15, help), tests (DB-less, real PostgreSQL, jsdom, Chrome)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-12 11:08:56 +09:00

206 lines
11 KiB
Python

"""관리자 등급(2026-10-12) — 수퍼관리자 > Admin > Pro user > User 별 프로젝트·목표·회의록 권한. DB 없이."""
import importlib
import tempfile
import unittest
from unittest.mock import MagicMock, patch
from fastapi import FastAPI
from fastapi.testclient import TestClient
from app.modules.project import access
from app.store import SUPER_ADMIN_EMAIL, UserStore, is_admin
api = importlib.import_module("app.modules.project.router")
SUPER = {"email": SUPER_ADMIN_EMAIL, "role": "admin"}
ADMIN = {"email": "admin@test.local", "role": "admin"}
PRO = {"email": "pro@test.local", "role": "pro"}
USER = {"email": "user@test.local", "role": "user"}
OUTSIDER_PRO = {"email": "pro2@test.local", "role": "pro"} # 프로젝트 1 멤버가 아닌 Pro user
class FakeStore(MagicMock):
"""프로젝트 1 = admin·pro·user 멤버(pro2 는 아님). 나머지 메서드는 MagicMock 이 받아 준다."""
MEMBERS = {1: {"admin@test.local", "pro@test.local", "user@test.local"}}
def is_member(self, project_id, user_email):
return user_email in self.MEMBERS.get(int(project_id), set())
def list_projects(self, include_archived=False, member_email=None):
return [{"id": pid, "parent_id": None} for pid, ms in self.MEMBERS.items()
if member_email is None or member_email in ms]
def get_project(self, project_id):
return {"id": project_id, "name": "P1", "owner_email": "admin@test.local", "created_by": "admin@test.local"}
def get_task(self, task_id):
# 남(admin)이 만든 작업
return {"id": task_id, "project_id": 1, "title": "t", "created_by": "admin@test.local"}
def get_stage(self, stage_id):
return {"id": stage_id, "project_id": 1, "created_by": "admin@test.local"}
def task_link_scope(self, task_ids):
return {}
class RoleHelperTests(unittest.TestCase):
def test_role_of(self):
self.assertEqual(access.role_of(SUPER), "super")
self.assertEqual(access.role_of(ADMIN), "admin")
self.assertEqual(access.role_of(PRO), "pro")
self.assertEqual(access.role_of(USER), "user")
self.assertEqual(access.role_of({"email": "x@test.local", "role": "weird"}), "user")
self.assertEqual(access.role_of(None), "user")
def test_pro_and_admin_flags(self):
self.assertEqual([access.is_pro(u) for u in (SUPER, ADMIN, PRO, USER)], [True, True, True, False])
self.assertEqual([access.is_project_admin(u) for u in (SUPER, ADMIN, PRO, USER)], [True, True, False, False])
# pro 는 프로젝트 모듈 밖(관리자 페이지 등)에서는 관리자가 아니다
self.assertFalse(is_admin(PRO))
def test_can_delete_project_or_section(self):
self.assertTrue(api._can_delete(ADMIN, "someone@test.local"))
self.assertTrue(api._can_delete(SUPER, "someone@test.local"))
self.assertFalse(api._can_delete(PRO, "someone@test.local"))
self.assertTrue(api._can_delete(PRO, "pro@test.local"))
self.assertTrue(api._can_delete(USER, "USER@test.local"))
# 만든 사람 기록이 없는 옛 데이터 — Admin 이상만
self.assertTrue(api._can_delete(ADMIN, ""))
self.assertFalse(api._can_delete(PRO, ""))
self.assertFalse(api._can_delete(USER, None))
def test_role_ctx(self):
self.assertEqual(api._role_ctx(PRO), {"is_admin": False, "pj_pro": True, "pj_admin": False})
self.assertEqual(api._role_ctx(ADMIN), {"is_admin": True, "pj_pro": True, "pj_admin": True})
self.assertEqual(api._role_ctx(USER), {"is_admin": False, "pj_pro": False, "pj_admin": False})
class UserStoreRoleTests(unittest.TestCase):
def setUp(self):
d = tempfile.mkdtemp(prefix="users-")
self.us = UserStore(__import__("pathlib").Path(d) / "users.json")
def test_pro_role_saved_and_validated(self):
rec = self.us.create_user(email="p@test.local", role="pro")
self.assertEqual(rec["role"], "pro")
self.assertFalse(any(rec["modules"].values())) # pro 도 모듈은 기본 꺼짐(user 와 같음)
rec = self.us.update_permissions(email="p@test.local", role="user", modules=None)
self.assertEqual(rec["role"], "user")
with self.assertRaises(ValueError):
self.us.create_user(email="x@test.local", role="super")
with self.assertRaises(PermissionError):
self.us.update_permissions(email=SUPER_ADMIN_EMAIL, role="pro", modules=None)
class RoleApiTests(unittest.TestCase):
def setUp(self):
self.st = FakeStore()
p = patch.object(access, "can_use_module", side_effect=lambda u: bool(u))
p.start()
self.addCleanup(p.stop)
app = FastAPI()
app.include_router(api.router)
app.state.data_dir = tempfile.mkdtemp(prefix="pj-roles-")
self.client = TestClient(app)
def call(self, who, method, url, **kw):
with patch.object(api, "_require_user", return_value=who), patch.object(api, "_db_or_503", return_value=self.st):
return self.client.request(method, url, **kw)
def test_create_project_pro_and_up(self):
self.st.create_project.return_value = {"id": 9, "name": "n"}
self.assertEqual(self.call(USER, "POST", "/project/api/projects", json={"name": "n"}).status_code, 403)
for who in (PRO, ADMIN):
self.assertEqual(self.call(who, "POST", "/project/api/projects", json={"name": "n"}).status_code, 201)
def test_subproject_any_member(self):
self.st.create_project.return_value = {"id": 10, "name": "s"}
r = self.call(USER, "POST", "/project/api/projects/1/subprojects", json={"name": "s"})
self.assertEqual(r.status_code, 201, r.text)
def test_edit_project_pro_member_only(self):
self.st.update_project.return_value = {"id": 1, "name": "x"}
self.assertEqual(self.call(USER, "PUT", "/project/api/projects/1", json={"name": "x"}).status_code, 403)
self.assertEqual(self.call(OUTSIDER_PRO, "PUT", "/project/api/projects/1", json={"name": "x"}).status_code, 403)
self.assertEqual(self.call(PRO, "PUT", "/project/api/projects/1", json={"name": "x"}).status_code, 200)
def test_owner_change_by_pro(self):
self.st.update_project.return_value = {"id": 1}
with patch.object(api, "_check_owner_candidate"):
r = self.call(PRO, "PUT", "/project/api/projects/1", json={"owner_email": "user@test.local"})
self.assertEqual(r.status_code, 200, r.text)
def test_delete_project_admin_any_pro_own(self):
self.st.delete_project.return_value = []
self.assertEqual(self.call(PRO, "DELETE", "/project/api/projects/1").status_code, 403) # admin 이 만든 것
self.assertEqual(self.call(ADMIN, "DELETE", "/project/api/projects/1").status_code, 200)
def test_members_pro_in_own_project(self):
self.st.add_member.return_value = {"user_email": "x@test.local"}
body = {"user_email": "x@test.local"}
self.assertEqual(self.call(USER, "POST", "/project/api/projects/1/members", json=body).status_code, 403)
self.assertEqual(self.call(OUTSIDER_PRO, "POST", "/project/api/projects/1/members", json=body).status_code, 403)
self.assertEqual(self.call(PRO, "POST", "/project/api/projects/1/members", json=body).status_code, 201)
self.assertEqual(self.call(PRO, "DELETE", "/project/api/projects/1/members/x@test.local").status_code, 200)
def test_reorder_pro_and_up(self):
body = {"ordered_ids": [1]}
self.assertEqual(self.call(USER, "PUT", "/project/api/projects/order", json=body).status_code, 403)
self.assertEqual(self.call(PRO, "PUT", "/project/api/projects/order", json=body).status_code, 200)
# Pro user 라도 멤버가 아닌 프로젝트는 순서를 못 바꾼다(검토 2026-10-12)
self.assertEqual(self.call(OUTSIDER_PRO, "PUT", "/project/api/projects/order", json=body).status_code, 403)
def test_section_delete_admin_any_others_creator(self):
self.assertEqual(self.call(PRO, "DELETE", "/project/api/projects/1/stages/5").status_code, 403)
self.assertEqual(self.call(USER, "DELETE", "/project/api/projects/1/stages/5").status_code, 403)
self.assertEqual(self.call(ADMIN, "DELETE", "/project/api/projects/1/stages/5").status_code, 200)
def test_task_delete_any_member(self):
self.st.delete_task.return_value = ([7], None)
r = self.call(USER, "DELETE", "/project/api/tasks/7") # 남이 만든 작업도
self.assertEqual(r.status_code, 200, r.text)
self.assertEqual(self.call(OUTSIDER_PRO, "DELETE", "/project/api/tasks/7").status_code, 403)
def test_comment_edit_passes_pro_flag(self):
self.st.get_comment.return_value = {"id": 3, "task_id": 7, "author_email": "admin@test.local"}
self.st.update_comment.return_value = {"id": 3}
for who, flag in ((PRO, True), (USER, False)):
self.st.update_comment.reset_mock()
with patch.object(api, "_comment_task_access"):
self.call(who, "PUT", "/project/api/comments/3", json={"body": "b"})
self.assertEqual(self.st.update_comment.call_args.kwargs["is_admin"], flag)
def test_workload_summary_pro_only(self):
self.st.list_tasks_for_projects.return_value = []
self.st.list_subtasks_of.return_value = []
self.assertEqual(self.call(USER, "GET", "/project/api/projects/1/subtasks-summary").status_code, 403)
self.assertEqual(self.call(PRO, "GET", "/project/api/projects/1/subtasks-summary").status_code, 200)
def test_trash_restore_pro(self):
self.st.list_trash.return_value = [{"id": 4, "project_id": 1}] # 프로젝트 1 = PRO 가 멤버(list_projects)
self.st.restore_trash.return_value = {"restored": 1}
self.assertEqual(self.call(USER, "POST", "/project/api/trash/4/restore").status_code, 403)
self.assertEqual(self.call(PRO, "POST", "/project/api/trash/4/restore").status_code, 200)
def test_goals_input_pro_and_up(self):
body = {"metric": "sales", "kind": "target", "month": 1, "value": "10"}
self.assertEqual(self.call(USER, "PUT", "/project/api/goals/2026/metrics", json=body).status_code, 403)
self.assertEqual(self.call(PRO, "PUT", "/project/api/goals/2026/metrics", json=body).status_code, 200)
self.assertEqual(self.call(USER, "POST", "/project/api/goals/years", json={"year": 2027}).status_code, 403)
self.assertEqual(self.call(PRO, "POST", "/project/api/goals/years", json={"year": 2027}).status_code, 201)
self.assertEqual(self.call(USER, "DELETE", "/project/api/goals/2027").status_code, 403)
self.assertEqual(self.call(PRO, "DELETE", "/project/api/goals/2027").status_code, 200)
def test_meeting_complete_and_delete_pro(self):
self.st.set_meeting_completed.return_value = {"completed": True}
for url, method, kw in (("/project/api/goals/meetings/2026-10-12/complete", "POST", {"json": {"done": True}}),
("/project/api/goals/meetings/2026-10-12", "DELETE", {})):
self.assertEqual(self.call(USER, method, url, **kw).status_code, 403)
self.assertEqual(self.call(PRO, method, url, **kw).status_code, 200)
if __name__ == "__main__":
unittest.main()